> On Apr 18, 2019, at 12:21 AM, Jerin Jacob Kollanukkaran <[email protected]>
> wrote:
>
>
>> -----Original Message-----
>> From: Yongseok Koh <[email protected]>
>> Sent: Thursday, April 18, 2019 7:17 AM
>> To: [email protected]; Jerin Jacob Kollanukkaran
>> <[email protected]>; Pavan Nikhilesh Bhagavatula
>> <[email protected]>; [email protected]
>> Cc: [email protected]; [email protected]; [email protected];
>> [email protected]; [email protected]
>> Subject: [EXT] [PATCH v2 1/4] meson: disable octeontx for buggy compilers on
>> arm64
>> ----------------------------------------------------------------------
>> Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler
>> error"
>> for aarch64
>>
>> Fixes: bd77f2d64c44 ("event/octeontx: build with meson")
>> Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers")
>> Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on
>> arm64")
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>>
>> Signed-off-by: Yongseok Koh <[email protected]>
>
> Nit:
> [master] [dpdk.org] $ ./devtools/check-git-log.sh
> Wrong headline prefix:
> meson: disable octeontx for buggy compilers on arm64
I was aware but I thought that should be accepted. That seems to be drawback of
the script. The only way to make it silent is :
"event/meson.build: disable octeontx for ..."
I don't think you want this, do you?
I'll keep it as is but let me know if you have better way to fix it.
thanks,
Yongseok
>
> With above fix:
> Acked-by: Jerin Jacob <[email protected]>