On 4/29/2019 5:24 PM, Stephen Hemminger wrote: > On Mon, 29 Apr 2019 10:28:36 +0100 > Ferruh Yigit <ferruh.yi...@intel.com> wrote: > >>> >>> >>>> +* kni: Modify function return value for the sake of removing rte_panic >>>> + from the init sequence in version 19.08. >>>> + - In ``lib/librte_kni/rte_kni_fifo.h`` replace >>>> + ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned >>>> size)`` >>>> + to return ``int`` >>> >>> This is not a public API really so no deprecation needed. >>> It is just an include file used internally by library and the driver. >>> > > This does introduce the possibility of kernel/library version mismatch. > You might want to add a magic number to shared data structure. >
Changing 'kni_fifo_init()' return type shouldn't be a problem at all, perhaps it would be a problem if the content of the fifo changed but it is not the case.
