On Thu, May 16, 2019 at 07:04:03PM +0100, Kevin Traynor wrote:
> On 16/05/2019 16:54, Bruce Richardson wrote:
> > When including the rte_ether.h header in applications with warnings
> > enabled, a warning was given because of the assumption of 2-byte alignment
> > of ethernet addresses when processing them.
> >
> > .../include/rte_ether.h:149:2: warning: converting a packed ‘const
> > struct ether_addr’ pointer (alignment 1) to a ‘unaligned_uint16_t’
> > {aka ‘const short unsigned int’} pointer (alignment 2) may result in
> > an unaligned pointer value [-Waddress-of-packed-member]
> > 149 | const unaligned_uint16_t *ea_words = (const unaligned_uint16_t *)ea;
> > | ^~~~~
> >
>
> Hi - There was a couple of these warnings in telemetry that were not
> squashed with the patch to disable the warning in 19.05. I was just
> about send a patch to address that when I saw this one.
>
> As your patch is aiming for a better solution, I won't send my patch for
> master but I'll still send to stable.
>
Good idea, thanks.
