On Fri, Jun 28, 2019 at 9:20 PM David Marchand <david.march...@redhat.com> wrote:
> > On Fri, Jun 28, 2019 at 5:57 PM Thomas Monjalon <tho...@monjalon.net> > wrote: > >> 27/06/2019 13:33, David Marchand: >> > We had some inconsistencies between functions prototypes and actual >> > definitions. >> > Let's avoid this by only adding the experimental tag to the prototypes. >> > Tests with gcc and clang show it is enough. >> > >> > git grep -l __rte_experimental |grep \.c$ |while read file; do >> > sed -i -e '/^__rte_experimental$/d' $file; >> > sed -i -e 's/ *__rte_experimental//' $file; >> > sed -i -e 's/__rte_experimental *//' $file; >> > done >> >> There is one miss: >> >> rte_telemetry_parse is not flagged as experimental >> but is listed in version map >> Please add __rte_experimental to the definition of rte_telemetry_parse >> > > Not sure I get you. > How did you get this warning? > > Ah ok, this library is disabled by default. Another fix being cooked. Expect a v2 maybe later today, but I still need an answer on which approach we take :-) -- David Marchand
