> -----Original Message-----
> From: Babu Radhakrishnan, AgalyaX
> Sent: Friday, June 14, 2019 3:06 PM
> To: [email protected]
> Cc: Pattan, Reshma <[email protected]>; Dumitrescu, Cristian
> <[email protected]>; Babu Radhakrishnan, AgalyaX
> <[email protected]>
> Subject: [PATCH] examples: modify error message for ip pipeline
>
> From: Agalya Babu RadhaKrishnan <[email protected]>
>
> Added help command in error message for ip pipeline commands.
>
> Signed-off-by: Agalya Babu RadhaKrishnan
> <[email protected]>
> ---
> examples/ip_pipeline/cli.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
> index 309b2936e..8a651bbbc 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -30,12 +30,12 @@
>
> #define MSG_OUT_OF_MEMORY "Not enough memory.\n"
> #define MSG_CMD_UNKNOWN "Unknown command \"%s\".\n"
> -#define MSG_CMD_UNIMPLEM "Command \"%s\" not implemented.\n"
> -#define MSG_ARG_NOT_ENOUGH "Not enough arguments for command
> \"%s\".\n"
> -#define MSG_ARG_TOO_MANY "Too many arguments for command
> \"%s\".\n"
> -#define MSG_ARG_MISMATCH "Wrong number of arguments for
> command \"%s\".\n"
> -#define MSG_ARG_NOT_FOUND "Argument \"%s\" not found.\n"
> -#define MSG_ARG_INVALID "Invalid value for argument \"%s\".\n"
> +#define MSG_CMD_UNIMPLEM "Command \"%s\" not implemented. Try
> help <cmd>\n"
> +#define MSG_ARG_NOT_ENOUGH "Not enough arguments for command
> \"%s\". Try help <cmd>\n"
> +#define MSG_ARG_TOO_MANY "Too many arguments for command
> \"%s\". Try help <cmd>\n"
> +#define MSG_ARG_MISMATCH "Wrong number of arguments for
> command \"%s\". Try help <cmd>\n"
> +#define MSG_ARG_NOT_FOUND "Argument \"%s\" not found. Try help
> <cmd>\n"
> +#define MSG_ARG_INVALID "Invalid value for argument \"%s\". Try help
> <cmd>\n"
> #define MSG_FILE_ERR "Error in file \"%s\" at line %u.\n"
> #define MSG_FILE_NOT_ENOUGH "Not enough rules in file \"%s\".\n"
> #define MSG_CMD_FAIL "Command \"%s\" failed.\n"
> --
> 2.14.1
NAK
I don't see the value to add "try help command" on all the error messages, the
user is already aware that there is a help command available, and some people
might actually find this repetition annoying.
