Re: [dpdk-dev] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg

[Laatz, Kevin]

On 15/07/2019 11:54, Sean Morrissey wrote:

Added telemetry to EAL long options so that when
--telemetry is passed as an EAL arg that there is
no unrecognized argument error message printed.

Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
Cc: ciara.po...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Sean Morrissey <sean.morris...@intel.com>
---
  lib/librte_eal/common/eal_common_options.c | 3 +++
  lib/librte_eal/common/eal_options.h        | 4 ++++
  2 files changed, 7 insertions(+)

diff --git a/lib/librte_eal/common/eal_common_options.c 
b/lib/librte_eal/common/eal_common_options.c
index 512d5088e..24e36cf23 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -81,6 +81,9 @@ eal_long_options[] = {
        {OPT_LEGACY_MEM,        0, NULL, OPT_LEGACY_MEM_NUM       },
        {OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
        {OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
+#ifdef RTE_LIBRTE_TELEMETRY
+       {OPT_TELEMETRY,         0, NULL, OPT_TELEMETRY_NUM        },
+#endif
        {0,                     0, NULL, 0                        }
  };

diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h

index 9855429e5..e4c8e25c2 100644
--- a/lib/librte_eal/common/eal_options.h
+++ b/lib/librte_eal/common/eal_options.h
@@ -69,6 +69,10 @@ enum {
        OPT_IOVA_MODE_NUM,
  #define OPT_MATCH_ALLOCATIONS  "match-allocations"
        OPT_MATCH_ALLOCATIONS_NUM,
+#ifdef RTE_LIBRTE_TELEMETRY
+       #define OPT_TELEMETRY          "telemetry"
+               OPT_TELEMETRY_NUM,
+#endif
        OPT_LONG_MAX_NUM
  };

LGTM, thanks!

Acked-by: Kevin Laatz <kevin.la...@intel.com>