On 7/16/2019 4:40 PM, Stephen Hemminger wrote:
> The generic RTE_LOGTYPE_PMD is a historical relic and should
> not be used. Every driver must dynamic log types.
>
> Signed-off-by: Stephen Hemminger <[email protected]>
<...>
> @@ -161,16 +161,14 @@ ixgbe_add_tx_flow_control_drop_filter(struct
> rte_eth_dev *eth_dev)
> struct ixgbe_ethertype_filter ethertype_filter;
>
> if (!hw->mac.ops.set_ethertype_anti_spoofing) {
> - RTE_LOG(INFO, PMD, "ether type anti-spoofing is not"
> - " supported.\n");
> + PMD_DRV_LOG(INFO, "ether type anti-spoofing is not
> supported.\n");
> return;
> }
>
> i = ixgbe_ethertype_filter_lookup(filter_info,
> IXGBE_ETHERTYPE_FLOW_CTRL);
> if (i >= 0) {
> - RTE_LOG(ERR, PMD, "A ether type filter"
> - " entity for flow control already exists!\n");
> + PMD_DRV_LOG(ERR, "A ether type filter entity for flow control
> already exists!\n");
> return;
> }
>
This patch both adds dynamic log for Rx/Tx and converts log macro 'RTE_LOG' to
'PMD_DRV_LOG', can we separate these into two different patches?
