Re: [dpdk-dev] [PATCH v4 02/54] ethdev: change rte_eth_dev_info_get() return value to int

[Iremonger, Bernard]

Hi Andrew,

> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybche...@solarflare.com]
> Sent: Friday, September 13, 2019 11:37 AM
> To: Iremonger, Bernard <bernard.iremon...@intel.com>; Neil Horman
> <nhor...@tuxdriver.com>; Mcnamara, John <john.mcnam...@intel.com>;
> Kovacevic, Marko <marko.kovace...@intel.com>; Thomas Monjalon
> <tho...@monjalon.net>; Yigit, Ferruh <ferruh.yi...@intel.com>
> Cc: dev@dpdk.org; Ivan Ilchenko <ivan.ilche...@oktetlabs.com>
> Subject: Re: [dpdk-dev] [PATCH v4 02/54] ethdev: change
> rte_eth_dev_info_get() return value to int
> 
> Hi Bernard,
> 
> On 9/13/19 1:18 PM, Iremonger, Bernard wrote:
> > Hi Ivan,
> >
> >> -----Original Message-----
> >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew
> Rybchenko
> >> Sent: Thursday, September 12, 2019 5:42 PM
> >> To: Neil Horman <nhor...@tuxdriver.com>; Mcnamara, John
> >> <john.mcnam...@intel.com>; Kovacevic, Marko
> >> <marko.kovace...@intel.com>; Thomas Monjalon
> <tho...@monjalon.net>;
> >> Yigit, Ferruh <ferruh.yi...@intel.com>
> >> Cc: dev@dpdk.org; Ivan Ilchenko <ivan.ilche...@oktetlabs.com>
> >> Subject: [dpdk-dev] [PATCH v4 02/54] ethdev: change
> >> rte_eth_dev_info_get() return value to int
> >>
> >> From: Ivan Ilchenko <ivan.ilche...@oktetlabs.com>
> >>
> >> Change rte_eth_dev_info_get() return value from void to int and
> >> return negative errno values in case of error conditions.
> >> Modify rte_eth_dev_info_get() usage across the ethdev according to
> >> new return type.
> >>
> >> Signed-off-by: Ivan Ilchenko <ivan.ilche...@oktetlabs.com>
> >> Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com>
> >> Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>
> > ./check-git-log.sh -1
> > Wrong headline format:
> >          ethdev: change rte_eth_dev_info_get() return value to int
> 
> In this particular case we decided (may be incorrectly) that it would be more
> harm if we rephrase it without mentioning function name.
> It is trivial to fix. No strong opinion.
> 
> My main goal of yesterday re-spin was to check build with missing patch
> applied to DPDK main repo, but unfortunately there are still some build
> issues (meson column) which I don't understand.
> 
> Andrew.

Probably best to fix it in next version.

Regards,

Bernard.