> -----Original Message----- > From: Ye, Xiaolong > Sent: Monday, September 23, 2019 16:30 > To: Yang, Qiming <[email protected]> > Cc: Rong, Leyi <[email protected]>; Wang, Haiyue <[email protected]>; > Lu, Wenzhuo > <[email protected]>; Zhang, Qi Z <[email protected]>; [email protected] > Subject: Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction > support for per Rx queue > > On 09/23, Yang, Qiming wrote: > > > > > > [snip] > > >> @@ -1378,9 +1666,18 @@ static int ice_parse_devargs(struct rte_eth_dev > >> *dev) > >> return -EINVAL; > >> } > >> > >> + memset(ad->devargs.proto_xtr, PROTO_XTR_NONE, > >> + sizeof(ad->devargs.proto_xtr)); > >> + > >> + ret = rte_kvargs_process(kvlist, ICE_PROTO_XTR_ARG, > >> + &handle_proto_xtr_arg, &ad->devargs); > >> + if (ret) > >> + goto bail; > >> + > > > >Why is bail? > > > > Minor nit, better to snip unrelated context for one single comment, otherwise > it's quite difficult to find it. :) >
+1, I checked many lines very carefully to avoid miss something. :) > Thanks, > Xiaolong
