> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Sunday 27 October 2019 13:27 > To: Power, Ciara <[email protected]> > Cc: dev <[email protected]>; Richardson, Bruce <[email protected]> > Subject: Re: [dpdk-dev] [PATCH] raw/ioat: enable xstats reset for ioat device > > On Wed, Oct 16, 2019 at 3:36 PM Bruce Richardson > <[email protected]> wrote: > > > > On Wed, Oct 16, 2019 at 02:16:26PM +0100, Ciara Power wrote: > > > The rawdev xstats_reset function is now enabled. It is called when > > > the ioat autotest completes, to reset all xstat values after they > > > have been modified during testing. > > > > > > Signed-off-by: Ciara Power <[email protected]> > > > > Reviewed-by: Bruce Richardson <[email protected]> > > This patch conflicts with the other series on this driver. > Is it really necessary to reset those statistics once the device has been > stopped? > > > -- > David Marchand
Hi David, It is a necessary change because stopping the device does not reset the stats, which will result in them accumulating if the test is run multiple times. Resetting the stats after stopping the device solves this problem. I can rebase onto master to resolve the conflict, and send a new version for this patch if it helps. Thanks, - Ciara
