Hello Laurent, Bonne année.
Cc: maintainers. On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy <laurent.ha...@6wind.com> wrote: > > In current led control API we have no way to know if a device is able > to handle on/off requests coming from the application. > Knowing if the device is led control capable could be useful to avoid > exchanges between application and kernel. > Using the on/off requests to flag if the device is led control capable > (based on the ENOSUP returned error) is not convenient as such request > can change the led state on device. > > This patch adds a new function rte_eth_led_ctrl_capable() that will look > for led_off/on dev ops availability on the related pmd, to know if the > device is able to handle such led control requests (on/off). This patch breaks the ABI, which is BAD :-). This new api only needs to look at the existing ops, so you can remove the (unused in your patch) dev_led_ctrl_capable ops. OTOH, would it make sense to expose this capability in dev_flags? -- David Marchand
