> -----Original Message-----
> From: Thomas Monjalon <[email protected]>
> Sent: Friday, January 10, 2020 17:14
> To: Wang, Haiyue <[email protected]>; Matan Azrad <[email protected]>
> Cc: Maxime Coquelin <[email protected]>; Bie, Tiwei
> <[email protected]>; Wang, Zhihong
> <[email protected]>; Wang, Xiao W <[email protected]>; Yigit, Ferruh
> <[email protected]>;
> [email protected]; Andrew Rybchenko <[email protected]>
> Subject: Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA
> class
>
> 10/01/2020 10:07, Matan Azrad:
> > From: Wang, Haiyue
> > > From: Matan Azrad
> > > > > delete mode 100644 doc/guides/nics/ifc.rst create mode 100644
> > > > > doc/guides/vdpadevs/features/ifcvf.ini
> > > > > create mode 100644 doc/guides/vdpadevs/ifc.rst delete mode 100644
> > > > > drivers/net/ifc/Makefile delete mode 100644
> > > > > drivers/net/ifc/base/ifcvf.c delete mode 100644
> > > > > drivers/net/ifc/base/ifcvf.h delete mode 100644
> > > > > drivers/net/ifc/base/ifcvf_osdep.h
> > > > > delete mode 100644 drivers/net/ifc/ifcvf_vdpa.c delete mode 100644
> > > > > drivers/net/ifc/meson.build delete mode 100644
> > > > > drivers/net/ifc/rte_pmd_ifc_version.map
> > > > > create mode 100644 drivers/vdpa/ifc/Makefile create mode 100644
> > > > > drivers/vdpa/ifc/base/ifcvf.c create mode 100644
> > > > > drivers/vdpa/ifc/base/ifcvf.h create mode 100644
> > > > > drivers/vdpa/ifc/base/ifcvf_osdep.h
> > > > > create mode 100644 drivers/vdpa/ifc/ifcvf_vdpa.c create mode
> > > > > 100644 drivers/vdpa/ifc/meson.build create mode 100644
> > > > > drivers/vdpa/ifc/rte_pmd_ifc_version.map
> > > > >
> > >
> > > git mv drivers/net/ifc/ drivers/vdpa/ifc ? ;-)
> >
> > Yes, and more file move in docs. (you can see like rename in git 😊)
> > Adjusted also the classes makefiles\measons to remove from net and to add
> > in vdpa.
> > Also MAINTAINER file etc...
>
> I think the comment from Haiyue was about the files deleted and created
> in the patch, instead of being moved (renamed).
Yes, I moved one Intel PMD code, then the patch is very small, it is like:
rename drivers/{net/iavf/base => common/iavf}/iavf_common.c (100%)
rename drivers/{net/iavf/base => common/iavf}/iavf_devids.h (100%)
detail is : https://patchwork.dpdk.org/patch/64384/
> As far as I know, this is for 2 reasons:
> - there is no move in internal git representation
> - some versions of git-diff does not detect moves properly,
> but option -M may help
>
