Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh <[email protected]> > Sent: Wednesday, January 15, 2020 4:29 PM > To: Iremonger, Bernard <[email protected]>; [email protected]; > Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>; > Doherty, Declan <[email protected]> > Cc: Ananyev, Konstantin <[email protected]>; Byrne, Stephen1 > <[email protected]>; Zhang, Helin <[email protected]> > Subject: Re: [dpdk-dev] [PATCH v6 03/13] app/testpmd: dump Rx and Tx > mbuf > > On 1/15/2020 3:53 PM, Bernard Iremonger wrote: > > add call to rte_pktmbuf_dump() in dump_pkt_burst in util.c > > > > Signed-off-by: Bernard Iremonger <[email protected]> > > --- > > app/test-pmd/util.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index > > b514be5..bf03873 100644 > > --- a/app/test-pmd/util.c > > +++ b/app/test-pmd/util.c > > @@ -158,6 +158,7 @@ dump_pkt_burst(uint16_t port_id, uint16_t queue, > struct rte_mbuf *pkts[], > > printf(" ol_flags: %s\n", buf); > > if (rte_mbuf_check(mb, 1, &reason) < 0) > > printf("INVALID mbuf: %s\n", reason); > > + rte_pktmbuf_dump(stdout, pkts[i], pkts[i]->data_len); > > } > > } > > > > > > I am not sure about this change, 'dump_pkt_burst' is good for debugging and > getting the packet metadata, but having mbuf dump for each packet can > make it very verbose and harder to use. > If there is a need for it, can we add it with another command? > like verbose value 0,1,2,3 defines the dump_pkt_burst level, why not add a > new level to dump mbuf?
This is only printed for verbose levels 1 (rx) and 3 (rx+tx). Normally used for debugging a small number or burst of packets. If you think it is too verbose I can live without this patch. Regards, Bernard.
