Hi Marcin,
> -----Original Message-----
> From: Smoczynski, MarcinX <marcinx.smoczyn...@intel.com>
> Sent: Wednesday, January 15, 2020 6:28 PM
> To: akhil.go...@nxp.com; Ananyev, Konstantin
> <konstantin.anan...@intel.com>; Zhang, Roy Fan
> <roy.fan.zh...@intel.com>; Doherty, Declan <declan.dohe...@intel.com>;
> Nicolau, Radu <radu.nico...@intel.com>
> Cc: dev@dpdk.org; Smoczynski, MarcinX <marcinx.smoczyn...@intel.com>
> Subject: [PATCH v3 1/6] cryptodev: introduce cpu crypto support API
>
> Add new API allowing to process crypto operations in a synchronous manner.
> Operations are performed on a set of SG arrays.
>
> Sync mode is selected by setting appropriate flag in an xform type number.
> Cryptodevs which allows CPU crypto operation mode have to use
> RTE_CRYPTODEV_FF_SYM_CPU_CRYPTO capability.
>
> Signed-off-by: Konstantin Ananyev <konstantin.anan...@intel.com>
> Signed-off-by: Marcin Smoczynski <marcinx.smoczyn...@intel.com>
> ---
> lib/librte_cryptodev/rte_crypto_sym.h | 62 ++++++++++++++++++-
> lib/librte_cryptodev/rte_cryptodev.c | 30 +++++++++
> lib/librte_cryptodev/rte_cryptodev.h | 20 ++++++
> lib/librte_cryptodev/rte_cryptodev_pmd.h | 19 ++++++
> .../rte_cryptodev_version.map | 1 +
> 5 files changed, 131 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_cryptodev/rte_crypto_sym.h
> b/lib/librte_cryptodev/rte_crypto_sym.h
> index ffa038dc4..f5dd05ab0 100644
> --- a/lib/librte_cryptodev/rte_crypto_sym.h
> +++ b/lib/librte_cryptodev/rte_crypto_sym.h
> @@ -25,6 +25,59 @@ extern "C" {
> #include <rte_mempool.h>
> #include <rte_common.h>
>
> +/**
> + * Crypto IO Vector (in analogy with struct iovec)
> + * Supposed be used to pass input/output data buffers for crypto
> +data-path
> + * functions.
> + */
> +struct rte_crypto_vec {
> + /** virtual address of the data buffer */
> + void *base;
> + /** IOVA of the data buffer */
> + rte_iova_t *iova;
> + /** length of the data buffer */
> + uint32_t len;
> +};
> +
> +struct rte_crypto_sgl {
> + /** start of an array of vectors */
> + struct rte_crypto_vec *vec;
> + /** size of an array of vectors */
> + uint32_t num;
> +};
> +
> +struct rte_crypto_sym_vec {
> + /** array of SGL vectors */
> + struct rte_crypto_sgl *sgl;
> + /** array of pointers to IV */
> + void **iv;
> + /** array of pointers to AAD */
> + void **aad;
> + /** array of pointers to digest */
> + void **digest;
> + /**
> + * array of statuses for each operation:
> + * - 0 on success
> + * - errno on error
> + */
> + int32_t *status;
> + /** number of operations to perform */
> + uint32_t num;
> +};
> +
> +/**
> + * used for cpu_crypto_process_bulk() to specify head/tail offsets
> + * for auth/cipher processing.
> + */
> +union rte_crypto_sym_ofs {
> + uint64_t raw;
> + struct {
> + struct {
> + uint16_t head;
> + uint16_t tail;
> + } auth, cipher;
> + } ofs;
> +};
>
> /** Symmetric Cipher Algorithms */
> enum rte_crypto_cipher_algorithm {
> @@ -425,7 +478,14 @@ enum rte_crypto_sym_xform_type {
> RTE_CRYPTO_SYM_XFORM_NOT_SPECIFIED = 0, /**< No
> xform specified */
> RTE_CRYPTO_SYM_XFORM_AUTH, /**< Authentication
> xform */
> RTE_CRYPTO_SYM_XFORM_CIPHER, /**< Cipher xform */
> - RTE_CRYPTO_SYM_XFORM_AEAD /**< AEAD xform */
> + RTE_CRYPTO_SYM_XFORM_AEAD, /**< AEAD xform */
> +
> + RTE_CRYPTO_SYM_XFORM_TYPE_MASK = 0xFFFF,
> + /**< xform type mask value */
> + RTE_CRYPTO_SYM_XFORM_FLAG_MASK = 0xFFFF0000,
> + /**< xform flag mask value */
> + RTE_CRYPTO_SYM_CPU_CRYPTO = 0x80000000,
> + /**< xform flag for cpu-crypto */
> };
>
Fan: what I believe RTE_CRYPTO_SYM_XFORM_TYPE_MASK and
RTE_CRYPTO_SYM_XFORM_FLAG_MASK should be define outside the enum, but as a
marco define. Also I think we missed a doc update patch in the patchset.
Other than that everything looks great.
