On 1/29/2020 5:44 PM, David Marchand wrote: > On Tue, Jan 28, 2020 at 6:35 PM Ferruh Yigit <ferruh.yi...@intel.com> wrote: >> On 1/27/2020 10:30 AM, Hariprasad Govindharajan wrote: >>> In current version, there is a function which parses >>> the corelist based on user value. A new generic >>> function eal_parse_optionlist is added which will >>> parse corelist as well as similar user input so >>> that we can use it as a public API too. >>> >>> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindhara...@intel.com> >> >> Hi David, >> >> Overall this patchset is to add '--portlist' command to testpmd and remove >> existing 64 port limitation. >> >> And in this patch re-uses the exiting parser function in eal and converts it >> to >> API, question is if eal is good place to have this API, what do you think >> about it? > > Exporting string parsers from the EAL has little value. > Ok we avoid code duplication (and I can see other places in the tree > where it might be used), but in the end we will have to maintain this > API in the ABI when it enters the stable ABI. > > I am for avoiding this. > >
The same function can be used in some sample applications too (which are using port mask), so instead of duplicating it multiple times, it would be nice to have this function somewhere that applications can use. Does it makes sense to have a rte_util.c (under in eal or as a separate library) to have this kind of application helper functions?
