04/02/2020 11:03, Gaetan Rivet: > On 03/02/2020 23:21, Thomas Monjalon wrote: > > 03/02/2020 06:16, Pavan Nikhilesh Bhagavatula: > >> @David Marchand @tho...@monjalon.net > >> > >> Ping? > >> > >> Are there any more changes required for this patch? It's been in queue > >> since last October. > > > > Sorry we have not decided whether it is a good idea or not. > > > > All changes related to probing are very sensitive, > > and we know a big refactoring would be better than stacking > > more and more options and corner cases. > > > > As we are busy with ABI stability stuff, we did not allocate > > enough time to properly think about this feature. > > Please accept our apologies, and let's consider it as > > a high priority for 20.05 cycle. > > > > Hello Thomas, > > This is unfortunate. I pushed Pavan to accept an alternative implementation > of this functionality that was less obtrusive, to make the integration > smoother. I took care to alleviate those risks from the common path. > > The big refactoring is needed yes, but considering the current path I'm not > seeing it happen in 20.05. If that means taking this patch as-is in 20.05 for > Marvell users, I'm not sure much is gained from waiting 3 months, except > minimal risk avoidance.
Yes, life is full of bad decisions and consequences. I still think there is a risk in adding new user expectations, and maintaining some code to workaround unknown issues. The real question here is to know why this patch? Is it to workaround a broken driver? Or to workaround a broken design in EAL and bus drivers?
