On Wed, Mar 11, 2020 at 6:08 PM Aaron Conole <[email protected]> wrote: > > David Marchand <[email protected]> writes: > > > On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren > > <[email protected]> wrote: > >> > >> This commit releases all service cores from their role, > >> returning them to ROLE_RTE on rte_service_finalize(). > >> > >> This may fix an issue relating to the service cores causing > > > > You don't seem convinced. > > > > > >> a race-condition on eal_cleanup(), where the service core > >> could still be executing while the main thread has already > >> free-d the service memory, leading to a segfault. > >> > >> Fixes: 21698354c832 ("service: introduce service cores concept") > >> Cc: [email protected] > >> > >> Reported-by: David Marchand <[email protected]> > >> Reported-by: Aaron Conole <[email protected]> > >> Signed-off-by: David Marchand <[email protected]> > >> Signed-off-by: Harry van Haaren <[email protected]> > >> Acked-by: Aaron Conole <[email protected]> > > > > I am okay with merging this so that we stop getting random failures of the > > ut. > > I think it could also potentially cause errors in user applications that > regularly exit, and which use the service core architecture. So it's > worth getting in now, anyway.
Indeed, thanks for the precision. In my defense, we did not get report of such crashes out of the CI. The CI is the main reason why I (selfishly :-)) have been pressing on this issue. -- David Marchand
