On Fri, Feb 20, 2015 at 10:01:10AM +0100, Thomas Monjalon wrote:
> Hi Danny,
>
> 2015-02-20 01:08, Zhou Danny:
> > @@ -148,6 +151,7 @@ struct rte_pci_device {
> > struct rte_pci_id id; /**< PCI ID. */
> > struct rte_pci_resource mem_resource[PCI_MAX_RESOURCE]; /**< PCI
> > Memory Resource */
> > struct rte_intr_handle intr_handle; /**< Interrupt handle */
> > + char kernel_driver_name[BUFSIZ]; /**< Kernel driver name */
>
> The comment is not very helpful.
> What about something like "Kernel driver to map ressources in userspace"?
>
> You are introducing a new field without filling it for UIO and VFIO.
>
> Testuya and Michael are working on the same thing in hotplug patchset:
> http://dpdk.org/dev/patchwork/patch/3520/
> Please help to choose the best approach.
>
> > const struct rte_pci_driver *driver; /**< Associated driver */
>
Hi Thomas,
since Danny is now off on Chinese New Year break, I'll look into this and see
about sending an updated patch set if I can today.
Regards,
/Bruce
