2015-02-20 14:54, Gajdzica, MaciejX T: > > 2015-02-19 18:26, Michal Jastrzebski: > > > From: Maciej Gajdzica <maciejx.t.gajdzica at intel.com> > > > > > > Changed MAC address type from uint8_t[6] to struct ether_addr and IP > > > address type from uint8_t[4] to uint32_t. Also removed union from > > > arp_hdr struct. Updated test-pmd to match new arp_hdr version. > > > > > > Signed-off-by: Maciej Gajdzica <maciejx.t.gajdzica at intel.com> > > > > Why? > > "Changed A to B" is not a sufficient explanation. > > Hi Thomas > > I changed commit message to this: > > Changed MAC address type from uint8_t[6] to struct ether_addr and IP > address type from uint8_t[4] to uint32_t to make it consistent with other > DPDK code using MAC and IP addresses. It allows us to use is_same_ether_addr > and ether_addr_copy functions on MAC addresses in ARP header. Also > removed union from arp_hdr struct to make calls to arp_data items > shorter. Updated test-pmd to match new arp_hdr version. > > Is that sufficient?
Yes it's far better! Thanks One day we could have a script to run before sending a patch. It would make some smoky tests and ask: "did you explain why you make this change?" ;) > This e-mail and any attachments may contain confidential material for the > sole use of the intended recipient(s). Any review or distribution by others > is strictly prohibited. If you are not the intended recipient, please contact > the sender and delete all copies. Please try to remove this footer. This email was distributed by the mailing list engine, despite it's prohibited. I don't want to go in jailhouse ;)
