> -----Original Message----- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Monday, February 9, 2015 10:55 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when > read > > On Mon, 9 Feb 2015 22:48:36 +0000 > "Dumitrescu, Cristian" <cristian.dumitrescu at intel.com> wrote: > > > Hi Stephen, > > > > What is the reason not to clear statistics on read? Do you have a use-case / > justification for it? > > > > (BTW, I see you added the reset functions, but was it also your intention to > remove the memset to 0 from the stats read functions? :) ) > > > > Regards, > > Cristian > > Read and clear is a non-standard model. Interface statistics are not > read/clear. > We have lots of scripts that read statistics. Users don't like it if when > stastics disappear.
Stephen, I suggest adding a new build-time configuration option for the librte_sched library in config/common_* files: CONFIG_RTE_SCHED_STATS_CLEAR_ON_READ. - When set to YES, we clear the stats counters on read. When set to NO, we do not clear stats counters on read; - The default value for this configuration option should be YES, in order to preserve the backward compatibility with the current behavior; - The stats reset functions introduced by this patch should always be enabled/compiled into the code, regardless of whether this new option is set to YES or NO. What do you think? Regards, Cristian -------------------------------------------------------------- Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
