> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Thursday, April 30, 2020 12:04 PM > To: Ori Kam <or...@mellanox.com> > Cc: Thomas Monjalon <tho...@monjalon.net>; Matan Azrad > <ma...@mellanox.com>; Shahaf Shuler <shah...@mellanox.com>; Slava > Ovsiienko <viachesl...@mellanox.com>; David Christensen > <d...@linux.vnet.ibm.com>; dev <dev@dpdk.org>; Yigit, Ferruh > <ferruh.yi...@intel.com> > Subject: Re: [dpdk-dev] [PATCH] eal/ppc: fix redefine bool type > > On Thu, Apr 30, 2020 at 10:53 AM Ori Kam <or...@mellanox.com> wrote: > > > > diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h > > > b/lib/librte_eal/ppc/include/rte_memcpy.h > > > > index 25311ba..d234e21 100644 > > > > --- a/lib/librte_eal/ppc/include/rte_memcpy.h > > > > +++ b/lib/librte_eal/ppc/include/rte_memcpy.h > > > > @@ -8,13 +8,12 @@ > > > > > > > > #include <stdint.h> > > > > #include <string.h> > > > > -/*To include altivec.h, GCC version must >= 4.8 */ > > > > -#include <altivec.h> > > > > > > Why move the inclusion under the __cplusplus check? > > > > > Just to make it in the same part as other rte includes. > > "Normal" rte includes are usually standalone and "#ifdef __cplusplus" safe. > The rte_altivec.h header you added does not need any "#ifdef > __cplusplus" protection, but it might later). > > But otoh, "generic/" headers are special/internal headers and this is > why generic/rte_memcpy.h is under this check. > > So if there is no reason on your side, please leave rte_altivec.h > inclusion at the same place as the previous altivec.h. >
Sure, I will leave at the original place. Best, Ori > > Thanks. > > -- > David Marchand
