Ok, I'll modify it per you suggestion Thanks, Yuan Linsi ________________________________ 发件人: Ajit Khaparde <ajit.khapa...@broadcom.com> 发送时间: 2020年5月5日 11:42:20 收件人: Ferruh Yigit 抄送: Yuan,Linsi; Somnath Kotur; Lance Richardson; dpdk-dev 主题: Re: [dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing
On Thu, Apr 30, 2020 at 4:55 PM Ferruh Yigit <ferruh.yi...@intel.com<mailto:ferruh.yi...@intel.com>> wrote: On 4/30/2020 2:37 PM, Yuan Linsi wrote: > From: yuanlinsi01 <yuanlins...@baidu.com<mailto:yuanlins...@baidu.com>> > > We see a stack smashing as a result of defensive code missing. Once the > nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to > zero after doing a floor align, and we can not exit the following > receiving packets loop. And the buffers will be overwrite, then the > stack frame was ruined. > > Fix the problem by adding defensive code, once the nb_pkts is zero, just > directly return with no packets. > > Fixes: bc4a000f2 ("net/bnxt: implement SSE vector mode") > Cc: sta...@dpdk.org<mailto:sta...@dpdk.org> > > Signed-off-by: yuanlinsi01 > <yuanlins...@baidu.com<mailto:yuanlins...@baidu.com>> > Signed-off-by: rongdongsheng > <rongdongsh...@baidu.com<mailto:rongdongsh...@baidu.com>> Hi Yuan, For the sign-off tag, we need "Name Surname <em...@adress.com<mailto:em...@adress.com>>" syntax, for you I can see from mail thread that it is: "Signed-off-by: Linsi Yuan <yuanlins...@baidu.com<mailto:yuanlins...@baidu.com>>" Can you please share the same for the other sign-off, 'rongdongsheng'? Yuan, Can you please send the proper first-name, last-name for rongdongsheng? Thanks
