On 5/6/2020 11:14 PM, Ajit Khaparde wrote:
>
>
> On Wed, May 6, 2020 at 2:17 AM Ferruh Yigit <[email protected]
> <mailto:[email protected]>> wrote:
>
> On 5/5/2020 8:17 PM, Ajit Khaparde wrote:
> > From: Kishore Padmanabha <[email protected]
> <mailto:[email protected]>>
> >
> > Fix a buffer overrun issue spotted by coverity while accessing
> > the array ulp_device_params.
>
> If it is spotted by coverity, is there a coverity issue id?
>
> Yes. But in an internal scan.
> I haven't seen anything reported in this area in the latest coverity report
> against 20.05-rc1.
Thanks for checking, I wonder what is the difference so that it is not in public
converity.
Can you please mention in commit log that it is internal coverity, to prevent
same confusion later?
>
>
> >
> > Fixes: 313ac35ac701 ("net/bnxt: support ULP session manager init")
> >
> > Signed-off-by: Kishore Padmanabha <[email protected]
> <mailto:[email protected]>>
> > Reviewed-by: Michael Baucom <[email protected]
> <mailto:[email protected]>>
> > Reviewed-by: Ajit Khaparde <[email protected]
> <mailto:[email protected]>>
> > ---
> > drivers/net/bnxt/tf_ulp/ulp_template_db.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db.c
> b/drivers/net/bnxt/tf_ulp/ulp_template_db.c
> > index 86384169f..e89aefad4 100644
> > --- a/drivers/net/bnxt/tf_ulp/ulp_template_db.c
> > +++ b/drivers/net/bnxt/tf_ulp/ulp_template_db.c
> > @@ -321,7 +321,7 @@ struct bnxt_ulp_def_ident_info ulp_def_ident_tbl[]
> = {
> > }
> > };
> >
> > -struct bnxt_ulp_device_params ulp_device_params[] = {
> > +struct bnxt_ulp_device_params
> ulp_device_params[BNXT_ULP_DEVICE_ID_LAST] = {
> > [BNXT_ULP_DEVICE_ID_WH_PLUS] = {
> > .global_fid_enable = BNXT_ULP_SYM_YES,
> > .byte_order = (enum bnxt_ulp_byte_order)
> >
>
