21/05/2020 06:17, Honnappa Nagarahalli:
> <snip>
>
> > Subject: [dpdk-dev] [PATCH v2] ring: build on Window
> ^^^^ change this
> to 'eal'.
>
> Even though the compilation error points to rte_ring, this is not a issue in
> rte_ring library. Suggest changing the commit message to something like "eal:
> add per_lcore__rte_errno to export list for Windows".
The dedicated title prefix is "eal/windows:"
> > Exported per_lcore__rte_errno function to compile ring for windows.
> >
> > compilation error logs:
> > librte_ring_rte_ring.c.obj : error LNK2019: unresolved external symbol
> > per_lcore__rte_errno referenced in function rte_ring_lookup
> >
> > The cause was that per_lcore__rte_errno function wasn't included in the
> > export list.
> > To solve this per_lcore__rte_errno was added to the Windows export list.
> >
> > Signed-off-by: Fady Bader <f...@mellanox.com>
> > Depends-on: series-9374 ("Windows basic memory management")
> > ---
The "Depends-on" line is not supposed to be part of the merged commit.
The trick is to insert "---" line on top of such annotation,
so it will be automatically skipped when applying the patch with "git am".
We use the same trick for changelogs.
Reminder: a v2 patch should include a changelog and be sent with these options:
-v2 --annotate --in-reply-to 'MESSAGE-ID-OF-v1'
