22/05/2020 18:48, Bruce Richardson: > On Fri, May 22, 2020 at 10:04:44PM +0530, Jerin Jacob wrote: > > On Fri, May 22, 2020 at 7:21 PM Ciara Power <ciara.po...@intel.com> wrote: > > > > > > Initially, printf was used to indicate and error/warning resulting from > > > telemetry initialisation. This is now fixed to use EAL logs for > > > warnings, and the unnecessary printf for an error is removed. > > > > > > Fixes: eeb486f3ba65 ("eal: add telemetry as dependency") > > > Fixes: dd6275a424ac ("telemetry: fix error log output") > > > Cc: david.march...@redhat.com > > > > > > Signed-off-by: Ciara Power <ciara.po...@intel.com> > > > --- > > > --- a/lib/librte_eal/linux/eal.c > > > +++ b/lib/librte_eal/linux/eal.c > > > + if (error_str != NULL) > > > + RTE_LOG(WARNING, EAL, "%s\n", error_str); > > > > "EAL: No legacy callbacks, legacy socket not created" comes all the times > > now. > > Should we treat this as a warning? as it comes for with for the > > built-in applications? > > If it is important why not have a default handler in the EAL library? > > Perhaps the warning level could be changed to INFO. > BTW: if you compile with jansson library available, the legacy callbacks > will be available and this will be silenced.
Applied with log level set as NOTICE.