> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Sunday, May 24, 2020 5:39 PM > > 24/05/2020 17:31, Morten Brørup: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Sunday, May 24, 2020 5:12 PM > > > > > > 15/05/2020 15:08, guohongzhi: > > > > 1.rte_ipv4_cksum will return invalid checksum value like > 0xffff.(rfc1624) > > > > 2.__rte_raw_cksum should consider Big Endian. > > > > 3.checksum 0x0000 is invalid for udp, but valid for tcp.(rfc768) > > > > > > Please consider doing 3 patches, thanks. > > > > > > It was sent late for 20.05, I prefer not taking any risk, > > > and wait for maintainers approval. > > > The patches must be reviewed and discussed in 20.08 timeframe. > > > > This patch fixes a bug, which is incompatible with some very popular > Broadcom switch silicon, so the patch should be treated as such. > > > > However, I agree that the review responsibility is not Thomas' alone; > maintainers should step up if they consider this bugfix critical. > > Unfortunately, the lack of "Signed-off-by" is really blocking the merge. > I am not allowed adding such thing.
Agreed. A valid "Signed-off-by" with the contributor's actual name a legal requirement - and cannot be ignored. > > Given the bug was already there for a long time, > it is probably not so much critical anyway. Or someone has been debugging a production network for years and months, and finally managed to find the root cause of the problems experienced with the affected Broadcom switching silicon. Speaking from experience, the distance from production networks to network silicon software developers can be extremely long. ;-)
