18/02/2020 06:07, Jerin Jacob: > On Mon, Feb 17, 2020 at 9:08 PM Ferruh Yigit <ferruh.yi...@intel.com> wrote: > > > > For the ABI compatibility it is better to hide internal data structures > > from the application as much as possible. But because of some inline > > functions 'struct eth_dev_ops' can't be hidden completely. > > > > Plan is to split the 'struct eth_dev_ops' into two as ones used by > > inline functions and ones not used, and hide the second part that not > > used by inline functions completely to the application. > > It is a good improvement. IMO, If anything used in fast-path it > should be in ``struct rte_eth_dev`` > and rest can completely be moved to internal. In this case, if > `rte_eth_tx_descriptor_status` > not used on fastpath, Maybe we don't need to maintain the inline > status and move completely > to .c file. > > Those may be specifics of the work. In general, this change looks good to me. > > Acked-by: Jerin Jacob <jer...@marvell.com>
This ack is missing from v3. Jerin, please could you confirm on v3?