25/05/2020 02:37, Dmitry Kozlyuk:
> * eal_file_lock: lock or unlock an open file.
> * eal_file_truncate: enforce a given size for an open file.
[...]
> Implementation for Linux and FreeBSD is placed in "unix" subdirectory,
> which is intended for common code between the two. Files should be named
> after the ones from which the code is factored in OS subdirectory.
[...]
>  lib/librte_eal/unix/eal_unix.c             | 51 ++++++++++++++++++++++

Why naming this file eal_unix?
If it's truly global, it should be unix/eal.c
If it's only about file operations, it could be unix/eal_file.c

Please update MAINTAINERS when creating a new file.
All files or directories must be listed in MAINTAINERS,
even if there is no maintainer for them.



Reply via email to