On Mon, Jun 22, 2020 at 6:22 PM Thomas Monjalon <tho...@monjalon.net> wrote:
> 20/06/2020 15:32, Andrey Vesnovaty: > > Hi, and thanks a lot for your RFC v1 comments. > > > > RFC v2 emphasize the intent for sharing the flow action: > > * The term 'action context' was unclear and replaced with > > 'shared action'. > > * RFC v2 subject became 'add flow shared action API'. > > * all proposed APIs renamed according the above. > > > > The new shared action is an independent entity decoupled from any flow > > while any flow can reuse such an action. Please go over the RFC > > description, it was almost entirely rewritten. > > > > @Jerin Jacob: > > Thanks again for your comments, it made me admit that v1 description was > > incomplete & unclear. I hope v2 will be better at least in terms of > > clarity. > > @Thomas Monjalon: > > rte_flow_action_ctx_modify() -> rte_flow_action_ctx_modify() > > I guess it is a typo. > I see the name "rte_flow_shared_action_update" in the patch > > Right, a typo. Should be: rte_flow_action_ctx_modify() -> rte_flow_shared_action_update ()
