Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: support query RSS config in flow query

[Jeff Guo]

hi, chenxu

On 6/15/2020 10:18 AM, Chenxu Di wrote:
This patch support RSS action in flow query.
It can display the RSS configuration of the specified rule.


Could you add some example command here for better know the usage and 
the details.


Signed-off-by: Chenxu Di <chenxux...@intel.com>
---
  app/test-pmd/config.c | 55 +++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 55 insertions(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index f519246c7..7e3cccf9a 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1378,6 +1378,56 @@ port_flow_complain(struct rte_flow_error *error)
        return -err;
  }
  
+static void
+rss_config_display(struct rte_flow_action_rss *rss_conf)
+{
+       uint8_t i;
+
+       if (rss_conf == NULL) {
+               printf("Invalid rule\n");
+               return;
+       }
+
+       printf("RSS:\n"
+              " queues:");
+       if (rss_conf->queue_num == 0)
+               printf(" none");
+       for (i = 0; i < rss_conf->queue_num; i++)
+               printf(" %d", rss_conf->queue[i]);
+
+       printf("\n function:");
+       switch (rss_conf->func) {
+       case RTE_ETH_HASH_FUNCTION_DEFAULT:
+               printf(" default\n");
+               break;
+       case RTE_ETH_HASH_FUNCTION_TOEPLITZ:
+               printf(" toeplitz\n");
+               break;
+       case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR:
+               printf(" simple_xor\n");
+               break;
+       case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ:
+               printf(" symmetric_toeplitz\n");
+               break;
+       default:
+               printf(" Unknown function\n");
+               return;
+       }
+
+       printf(" types:\n");
+       if (rss_conf->types == 0) {
+               printf("  none\n");
+               return;
+       }
+       for (i = 0; rss_type_table[i].str; i++) {
+               if ((rss_conf->types &
+                   rss_type_table[i].rss_type) ==
+                   rss_type_table[i].rss_type &&
+                   rss_type_table[i].rss_type != 0)
+                       printf("  %s\n", rss_type_table[i].str);
+       }
+}
+
  /** Validate flow rule. */
  int
  port_flow_validate(portid_t port_id,
@@ -1564,6 +1614,7 @@ port_flow_query(portid_t port_id, uint32_t rule,
        const char *name;
        union {
                struct rte_flow_query_count count;
+               struct rte_flow_action_rss rss_conf;
        } query;
        int ret;
  
@@ -1585,6 +1636,7 @@ port_flow_query(portid_t port_id, uint32_t rule,
                return port_flow_complain(&error);
        switch (action->type) {
        case RTE_FLOW_ACTION_TYPE_COUNT:
+       case RTE_FLOW_ACTION_TYPE_RSS:
                break;
        default:
                printf("Cannot query action type %d (%s)\n",
@@ -1609,6 +1661,9 @@ port_flow_query(portid_t port_id, uint32_t rule,
                       query.count.hits,
                       query.count.bytes);
                break;
+       case RTE_FLOW_ACTION_TYPE_RSS:
+               rss_config_display(&query.rss_conf);
+               break;
        default:
                printf("Cannot display result for action type %d (%s)\n",
                       action->type, name);