Thanks. I will send the V2. -----邮件原件----- 发件人: Wisam Monther [mailto:wis...@mellanox.com] 发送时间: 2020年6月30日 22:10 收件人: oulijun <ouli...@huawei.com>; dev@dpdk.org; ferruh.yi...@intel.com 抄送: Linuxarm <linux...@huawei.com> 主题: RE: [dpdk-dev] [PATCH] app/testpmd: update uninitialized member when set fwd mode
Hi Lijun, >-----Original Message----- >From: dev <dev-boun...@dpdk.org> On Behalf Of Lijun Ou >Sent: Tuesday, June 30, 2020 4:25 PM >To: dev@dpdk.org; ferruh.yi...@intel.com >Cc: linux...@huawei.com >Subject: [dpdk-dev] [PATCH] app/testpmd: update uninitialized member >when set fwd mode The member is actually initialized before so I think the title somehow misleading, What about: "fix missing set for current forward engine" > >When set the forwarding mode of the pkt, it needs to update the fwd_eng >that it is the member of cur_fwd_config. Otherwise, an error will occur >when executing the set command and show confg fwd. >the flows as follows: > 1. ./tespmd -w xxx -l xx -n 4 -- i > 2. set fwd mac > testpmd> set fwd mac > Set mac packet forwarding mode > > 3. show config fwd > testpmd> show config fwd > io packet forwarding - ports=1 - cores=1 - streams=8 -... > Logical Core 1 (socket 0) forwards packets on 8 streams: > >When run the 1 ~ 3 step, it should show the packet forwarding is mac. I think this should be consider as a fix, and you need to add the fixed commit and cc It's auther > >Signed-off-by: Lijun Ou <ouli...@huawei.com> >--- > app/test-pmd/config.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index >a7112c9..ee0e904 100644 >--- a/app/test-pmd/config.c >+++ b/app/test-pmd/config.c >@@ -3158,6 +3158,7 @@ set_pkt_forwarding_mode(const char >*fwd_mode_name) > fwd_mode_name, > retry_enabled == 0 ? "" : " with retry"); > cur_fwd_eng = fwd_eng; >+ cur_fwd_config.fwd_eng = fwd_eng; > return; > } > i++; >-- >2.7.4
