Hi Akhil, thank you for these comments > > This patch should be split and merged to relevant other patches in the series. > rte_security related in 1/8 > Like aesni-mb related changes should go in 3/8 qat related should be part of > 4/8 crypto-perf should be part of 7/8 And release notes should also be split > into 3 different entries and squashed into Rte_security, qat and aesni-mb > patches.
[DC] I will make this change in v4. I will wait until there are more comments before submitting v4. > > + > > +The CRC is Ethernet CRC-32 as specified in Ethernet/[ISO/IEC 8802-3]. > > + > > +.. note:: > > + > > + * The CRC offset and length are specified via the auth offset and > > + length fields of the rte_crypto_sym_op. > > The above note is not correct. It should be > * The offset and length of data for which CRC need to be computed are > specified > via the auth offset and length fields of the rte_crypto_sym_op. [DC] Yes, that is a good clarification - I will make that update > > > > +* **Added support for DOCSIS protocol to rte_security.** > > + > > + Added support for combined crypto and CRC operations for the DOCSIS > > protocol > > + to ``rte_security``. Test and test-crypto-perf applications have > > + been updated for unit testing. > > Split this release note entry into two, 1 for 1/8 and one for 7/8 [DC] I will make this change
