Re: [dpdk-dev] [PATCH v3 4/8] fib: introduce AVX512 lookup

[Medvedkin, Vladimir]

Hi Thomas,

On 06/07/2020 20:21, Thomas Monjalon wrote:

19/05/2020 14:12, Vladimir Medvedkin:

--- a/lib/librte_fib/meson.build
+++ b/lib/librte_fib/meson.build
+if dpdk_conf.has('RTE_ARCH_X86') and cc.has_argument('-mavx512f')
+       if cc.has_argument('-mavx512dq')
+               dir24_8_avx512_tmp = static_library('dir24_8_avx512_tmp',
+                       'dir24_8_avx512.c',
+                       dependencies: static_rte_eal,
+                       c_args: cflags + ['-mavx512f'] + ['-mavx512dq'])
+               objs += dir24_8_avx512_tmp.extract_objects('dir24_8_avx512.c')
+               cflags += '-DCC_DIR24_8_AVX512_SUPPORT'
+       endif
+endif

I don't want to try understanding what this hack is.
But please add comments around it, so we will understand why
compilation fails:

In file included from ../../dpdk/lib/librte_fib/dir24_8_avx512.c:5:
../../dpdk/lib/librte_eal/x86/include/rte_vect.h:97:18: error: expected 
declaration specifiers or ‘...’ before ‘(’ token
    97 | #define ZMM_SIZE (sizeof(__x86_zmm_t))
       |                  ^

I sent v4 with slightly reworked meson.build, please check compilation.

--
Regards,
Vladimir