10.07.2020 18:22, Stephen Hemminger пишет: > On Fri, 10 Jul 2020 13:06:02 +0000 > "Yigit, Ferruh" <ferruh.yi...@intel.com> wrote: > >>> + /* ignore unknown specifier */ >>> + default: >>> + *str_cur = '%'; >>> + offset++; >>> + fmt_cur--; >>> + break; >> What do you think ignoring the unknown specifiers and keep continue >> processing the string, instead of break? Just keep unknown specifier >> as it is in the output string. > My comment was that the function should behave the same as > snprintf() does when handed unknown specifier. What snprintf > does is duplicate the string in the output buffer (like any > other non format character). Looks like I need to rewrite comment "ignore unkown specifier". It's not what code do. This function work like snprintf.
- [dpdk-dev] [PATCH v7 0/25] ethdev: allow unknown link sp... Ivan Dyukov
- [dpdk-dev] [PATCH v7 01/25] ethdev: allow unknown l... Ivan Dyukov
- [dpdk-dev] [PATCH v7 02/25] ethdev: add a link stat... Ivan Dyukov
- Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a l... Yigit, Ferruh
- Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add... Stephen Hemminger
- Re: [dpdk-dev] [PATCH v7 02/25] ethdev:... Yigit, Ferruh
- Re: [dpdk-dev] [PATCH v7 02/25] ethdev:... Ivan Dyukov
- Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add... Ivan Dyukov
- Re: [dpdk-dev] [PATCH v7 02/25] ethdev:... Yigit, Ferruh
- Re: [dpdk-dev] [PATCH v7 02/25] ethdev: add a l... Thomas Monjalon
- [dpdk-dev] [PATCH v7 03/25] app: UNKNOWN link speed... Ivan Dyukov
- [dpdk-dev] [PATCH v7 04/25] doc: update sample app ... Ivan Dyukov
- Re: [dpdk-dev] [PATCH v7 04/25] doc: update sam... Thomas Monjalon
- [dpdk-dev] [PATCH v7 07/25] net/ice: return unknown... Ivan Dyukov
- [dpdk-dev] [PATCH v7 05/25] net/ixgbe: return unkno... Ivan Dyukov
- [dpdk-dev] [PATCH v7 06/25] net/i40e: return unknow... Ivan Dyukov
- [dpdk-dev] [PATCH v7 08/25] examples: new link stat... Ivan Dyukov