On Fri, 10 Jul 2020 17:06:11 +0200 David Marchand <david.march...@redhat.com> wrote:
> On Sat, Jun 13, 2020 at 2:01 AM Stephen Hemminger > <step...@networkplumber.org> wrote: > > > > The terms blacklist and whitelist are often seen as reminders > > of the divisions in society. Instead, use more exact terms for > > handling of which devices are used in DPDK. > > > > This is a proposed change for DPDK 20.08 to replace the names > > blacklist and whitelist in API and command lines. > > > > The first three patches fix some other unnecessary use of > > blacklist/whitelist and have no user visible impact. > > > > The rest change the PCI blacklist to be blocklist and > > whitelist to be allowlist. > > Thanks for working on this. > > I agree, the first patches can go in right now. > > But I have some concerns about the rest. > > New options in EAL are not consistent with "allow"/"block" list: > + "b:" /* pci-skip-probe */ > + "w:" /* pci-only-probe */ > +#define OPT_PCI_SKIP_PROBE "pci-skip-probe" > + OPT_PCI_SKIP_PROBE_NUM = 'b', > +#define OPT_PCI_ONLY_PROBE "pci-only-probe" > + OPT_PCI_ONLY_PROBE_NUM = 'w', > > The CI flagged the series as failing, because the unit test for EAL > flags is unaligned: > +#define pci_allowlist "--pci-allowlist" > https://travis-ci.com/github/ovsrobot/dpdk/jobs/348668299#L5657 > > > The ABI check complains about the enum update: > https://travis-ci.com/github/ovsrobot/dpdk/jobs/348668301#L2400 > Either we deal with this, or we need a libabigail exception rule. > > > About deprecating existing API/EAL flags in this release, this should > go through the standard deprecation process. > I would go with introducing new options + full compatibility + a > deprecation notice in the 20.08 release. > The actual deprecation/API flagging will go in 20.11. > Removal will come later. > > The next version will use different flags, and the old flags will cause runtime deprecation warning.
