Re: [dpdk-dev] [PATCH v4 20/27] app/test: replace refernces to master/slave

[Burakov, Anatoly]

On 01-Jul-20 9:23 PM, Stephen Hemminger wrote:
Use initial and worker when referring to lcores
Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
---

You've changed the name of the test in test_eal_flags.c, but missed the 
update in meson.build to the new test name.

Also, you missed updating app/test/test_lpm_perf.c.

<snip>

diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c
index 981e212130bf..6b23363425c9 100644
--- a/app/test/test_service_cores.c
+++ b/app/test/test_service_cores.c
@@ -30,7 +30,7 @@ static int
  testsuite_setup(void)
  {
        slcore_id = rte_get_next_lcore(/* start core */ -1,
-                                      /* skip master */ 1,
+                                      /* skip initial */ 1,
                                       /* wrap */ 0);
  
  	return TEST_SUCCESS;
@@ -532,12 +532,12 @@ service_lcore_add_del(void)
        TEST_ASSERT_EQUAL(1, rte_service_lcore_count(),
                        "Service core count not equal to one");
        uint32_t slcore_1 = rte_get_next_lcore(/* start core */ -1,
-                                              /* skip master */ 1,
+                                              /* skip initial */ 1,
                                               /* wrap */ 0);
        TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_1),
                        "Service core add did not return zero");
        uint32_t slcore_2 = rte_get_next_lcore(/* start core */ slcore_1,
-                                              /* skip master */ 1,
+                                              /* skip initial */ 1,
                                               /* wrap */ 0);
        TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_2),
                        "Service core add did not return zero");
@@ -583,12 +583,12 @@ service_threaded_test(int mt_safe)
  
  	/* add next 2 cores */
        uint32_t slcore_1 = rte_get_next_lcore(/* start core */ -1,
-                                              /* skip master */ 1,
+                                              /* skip initial */ 1,
                                               /* wrap */ 0);
        TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_1),
                        "mt safe lcore add fail");
        uint32_t slcore_2 = rte_get_next_lcore(/* start core */ slcore_1,
-                                              /* skip master */ 1,
+                                              /* skip initial */ 1,
                                               /* wrap */ 0);
        TEST_ASSERT_EQUAL(0, rte_service_lcore_add(slcore_2),
                        "mt safe lcore add fail");

There are two more instances @ lines 926 and 929.

--
Thanks,
Anatoly