> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, January 19, 2015 5:23 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 11/17] librte_acl: add AVX2 as new > rte_acl_classify() method > > 2015-01-12 19:16, Konstantin Ananyev: > > +/* > > + * Select highest avaialbe classify method as default one. > > Typo here. > Actually, I've seen few typos when browsing your big patchset > but I don't remember exactly where. > Maybe that a tool like codespell could help. > > [...] > > > + else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1)) > > +#else > > if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1)) > > +#endif > > Minor nit, it could be > + else > +#endif > if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_SSE4_1))
I made it deliberately. >From my point, It seems more clear and easy to read with 'else if' at one line. Konstantin > > -- > Thomas