Got it. Thanks a lot.
在 2020-07-30 18:42:38，"Thomas Monjalon" <tho...@monjalon.net> 写道： >30/07/2020 12:39, Yi Yang (杨燚)-云服务集团: >> Thomas, do you mean I need to change the below files to add deprecation >> notice about free_cb? > >No it should be a separate patch for announing the deprecation in 20.08. > >Below patches cannot be applied in 20.08. > > >> >> doc/guides/rel_notes/deprecation.rst >> doc/guides/rel_notes/release_20_08.rst >> >> I'll use --cc-cmd devtools/get-maintainer.sh to send a new version including >> deprecation notice you mentioned. >> >> -----邮件原件----- >> 发件人: Thomas Monjalon [mailto:tho...@monjalon.net] >> 发送时间: 2020年7月30日 18:17 >> 收件人: yang_y...@163.com >> 抄送: dev@dpdk.org; jiayu...@intel.com; Yi Yang (杨燚)-云服务集团 >> <yangy...@inspur.com>; yang_y...@163.com; olivier.m...@6wind.com >> 主题: Re: [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case >> >> 30/07/2020 11:56, yang_y...@163.com: >> > --- a/lib/librte_mbuf/rte_mbuf.h >> > +++ b/lib/librte_mbuf/rte_mbuf.h >> > @@ -1193,7 +1193,7 @@ static inline void rte_pktmbuf_attach(struct >> > rte_mbuf *mi, struct rte_mbuf *m) >> > RTE_ASSERT(m->shinfo != NULL); >> > >> > if (rte_mbuf_ext_refcnt_update(m->shinfo, -1) == 0) >> > - m->shinfo->free_cb(m->buf_addr, m->shinfo->fcb_opaque); >> > + m->shinfo->free_cb(m, m->shinfo->fcb_opaque); >> > } >> > >> > /** >> > diff --git a/lib/librte_mbuf/rte_mbuf_core.h >> > b/lib/librte_mbuf/rte_mbuf_core.h index 8cd7137..d194429 100644 >> > --- a/lib/librte_mbuf/rte_mbuf_core.h >> > +++ b/lib/librte_mbuf/rte_mbuf_core.h >> > @@ -671,7 +671,7 @@ struct rte_mbuf { >> > /** >> > * Function typedef of callback to free externally attached buffer. >> > */ >> > -typedef void (*rte_mbuf_extbuf_free_callback_t)(void *addr, void >> > *opaque); >> > +typedef void (*rte_mbuf_extbuf_free_callback_t)(struct rte_mbuf *, >> > +void *); >> >> I think a deprecation notice is required in 20.08 in order to apply such >> change in 20.11. >> >> Please use --cc-cmd devtools/get-maintainer.sh when sending a patch. >> >> >> > > > >
