On 9/11/2020 7:46 AM, jiawe...@trustnetic.com wrote: > Should the changes for the first set be sent as an additional patch(maybe > several), or replace the exist patch set? It decides me to remake the 40+ > patches or not. >
Replace the existing set please, as a new version, v2 in this case. > > -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of Ferruh Yigit > Sent: Thursday, September 10, 2020 7:23 PM > To: jiawe...@trustnetic.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net: add a new network PMD named txgbe > > On 9/10/2020 8:16 AM, jiawe...@trustnetic.com wrote: >> Hi Ferruh, >> >> I am sorry that the patch work plan was disrupted due to other work inserted. >> But I have created another nearly 40 patches as the 2nd set. >> Should I send this set as a supplement to the previous one(as version v1 or >> v2?), or fix and verify the previous one firstly? > > I think better to fix the first set, this may cause changes in the second one. > >> >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yi...@intel.com> >> Sent: Thursday, September 10, 2020 1:45 AM >> To: jiawe...@trustnetic.com; dev@dpdk.org >> Subject: Re: [PATCH] net: add a new network PMD named txgbe >> >> On 9/1/2020 12:52 PM, jiawe...@trustnetic.com wrote: >>> Hi Ferruh, >>> >>> Since this patch is too large, it needs to be split into so many small >>> patches, which takes a lot of time. >> >> Thanks Jiawen for the work, I am aware it is not easy to arrange the patches >> and it takes time. >> Mostly looks good, I am putting some comments on new set. >> >>> Therefore, I first created a part of patches to contribute. And if there is >>> a review problem with these patches, please let me know as soon. >>> And I will complete the remaining patches in the next 3~4 days. >> >> Even it can go in multiple sets, first we can merge the initial set, you can >> verify and fix whatever exists, later can add more feature as separate sets. >> >>> >>> Thanks. >>> >>> -----Original Message----- >>> From: jiawe...@trustnetic.com <jiawe...@trustnetic.com> >>> Sent: Friday, August 21, 2020 10:22 AM >>> To: 'Ferruh Yigit' <ferruh.yi...@intel.com>; 'dev@dpdk.org' >>> <dev@dpdk.org> >>> Cc: 'jianw...@trustnetic.com' <jianw...@trustnetic.com>; >>> 'yuhongzh...@trustnetic.com' <yuhongzh...@trustnetic.com> >>> Subject: RE: [PATCH] net: add a new network PMD named txgbe >>> >>> Hi Ferruh, >>> >>> Thanks for your suggestion. I'll split the patch into a patchset as soon as >>> possible. >>> >>> -----Original Message----- >>> From: Ferruh Yigit <ferruh.yi...@intel.com> >>> Sent: Thursday, August 20, 2020 7:49 PM >>> To: Jiawen Wu <jiawe...@trustnetic.com>; dev@dpdk.org >>> Cc: jianw...@trustnetic.com; yuhongzh...@trustnetic.com >>> Subject: Re: [PATCH] net: add a new network PMD named txgbe >>> >>> On 8/20/2020 4:02 AM, Jiawen Wu wrote: >>>> This is a new network PMD named txgbe provides poll mode driver support >>>> for Wangxun 10Gb Ethernet NICs. >>>> >>>> Beijing WangXun Technology Co., Ltd. is a high-tech company specializing >>>> in the design of high-end integrated circuit chips and providing >>>> independent innovation solutions for enterprise network and storage >>>> products. Founded in May 2014, the company is headquartered in Beijing >>>> YuQuanHuiGu Science and Technology Park, with branches in Hangzhou City. >>>> Welcome to reach us on website https://www.net-swift.com. >>>> >>>> This patch is created base on the main branch in main repository. Our goal >>>> is to validate and commit txgbe driver into the 20.11 official release, >>>> and then continue the development and maintenance in community. >>>> >>>> Waiting for your reviews sincerely. >>>> >>>> Signed-off-by: Jiawen Wu <jiawe...@trustnetic.com> >>> >>> Hi Jiawen, >>> >>> Thanks for the patch. >>> >>> Without looking into any detail, a very high level comment is, it is very >>> hard to review a new PMD (40K+ loc) as a single patch. >>> >>> Can you please split the patch into multiple patches, which gradually build >>> the PMD by adding a feature with each patch, starting from an empty >>> skeleton. >>> >>> Last as few upstreamed PMDs as example: >>> ionic: >>> https://patches.dpdk.org/project/dpdk/list/?series=8206&state=%2A&arc >>> h >>> ive=both >>> >>> pfe: >>> https://patches.dpdk.org/project/dpdk/list/?series=6777&state=%2A&arc >>> h >>> ive=both >>> >>> octeontx2 (one of the good samples I suggest checking): >>> https://patches.dpdk.org/project/dpdk/list/?series=5302&state=%2A&arc >>> h >>> ive=both >>> >>> >>> Also you can skip all Makefile build system related changes, since it will >>> be removed in this release, no need to spend time for it. >>> >>> Thanks, >>> ferruh >>> >>> >>> >> >> >> >> > > > >