On Mon, Sep 14, 2020 at 6:03 PM Ferruh Yigit <ferruh.yi...@intel.com> wrote: <snip> > > Hi Lance, Ajit, Somnath, > > Raslan reported a build error for PPC architecture, this happens because > static inline functions in 'bnxt_rxtx_vec_common.h' are using > 'rxq->rxrearm_nb' & 'rxq->rxrearm_start' which are not defined for PPC. > > As far as I can see the 'bnxt_rxtx_vec_common.h' is included because of > some macros. > A quick fix can be to wrap all static inline functions with !PPC checks > but from the name of the header file, it looks like it shouldn't be > included by scalar datapath .c files at first place. > > Instead it can be possible to extract those macros into another header > and both these .c file and 'bnxt_rxtx_vec_common.h' can include it. > Or 'bnxt_txq.h' & 'bnxt_txr.h' can be used to hold those macros, and > those headers were already included by 'bnxt_rxtx_vec_common.h' and .c > files. > > > Anyway can you please provide the fix as incremental patches on top of > latest head, so I can squash them into original patches. > > If the patches can't be done as incremental fixes or if they will delay, > I will need to drop the patchset from next-net, to not block any > possible pull from main repo.
Hi Feruh, I just sent a fix for this based on the head of next-net, compile-tested on x86_64, arm64, and powerpc. Please let me know if you run into any further snags. Thanks, Lance