On Tue, Oct 6, 2020 at 10:23 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > The sub-directories of config/ are maintained by > different architecture maintainers. > > Some wildcards are used to describe the lib and drivers files > which are specific to some architectures.
I noticed "some" misses, see below. > > The EAL Arm files have split responsibilities depending on 32/64 suffix, > and the common files are shared between Armv7 and Armv8 sections. > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > --- > MAINTAINERS | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 75a17d51c0..349fc9c38a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -256,32 +256,31 @@ F: app/test/test_rand_perf.c > ARM v7 > M: Jan Viktorin <vikto...@rehivetech.com> > M: Ruifeng Wang <ruifeng.w...@arm.com> > +F: config/arm/ > F: lib/librte_eal/arm/ > +X: lib/librte_eal/arm/include/*_64.h > > ARM v8 > M: Jerin Jacob <jer...@marvell.com> > M: Ruifeng Wang <ruifeng.w...@arm.com> > -F: lib/librte_eal/arm/include/*_64.h > -F: lib/librte_net/net_crc_neon.h > -F: lib/librte_acl/acl_run_neon.* > -F: lib/librte_bpf/bpf_jit_arm64.c > -F: lib/librte_lpm/rte_lpm_neon.h > -F: lib/librte_hash/rte*_arm64.h > -F: lib/librte_efd/rte*_arm64.h > -F: lib/librte_table/rte*_arm64.h > -F: drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c > -F: drivers/net/i40e/i40e_rxtx_vec_neon.c > -F: drivers/net/virtio/virtio_rxtx_simple_neon.c > +F: config/arm/ > +F: lib/librte_eal/arm/ > +X: lib/librte_eal/arm/include/*_32.h > +F: lib/*/*_neon.* > +F: lib/*/*_arm64.* > +F: drivers/*/*/*_neon.* app and examples directory are not caught in this: ./lib/librte_net/net_crc_neon.h ./lib/librte_acl/acl_run_neon.h ./lib/librte_acl/acl_run_neon.c ./lib/librte_lpm/rte_lpm_neon.h ./lib/librte_node/ip4_lookup_neon.h ./examples/l3fwd/l3fwd_lpm_neon.h ./examples/l3fwd/l3fwd_em_hlm_neon.h ./examples/l3fwd/l3fwd_neon.h ./app/test-pmd/macswap_neon.h ./drivers/net/hns3/hns3_rxtx_vec_neon.h ./drivers/net/bnxt/bnxt_rxtx_vec_neon.c ./drivers/net/mlx5/mlx5_rxtx_vec_neon.h ./drivers/net/virtio/virtio_rxtx_simple_neon.c ./drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c ./drivers/net/i40e/i40e_rxtx_vec_neon.c Can we use a wildcard at dpdk root? */*/*_neon.* The drivers/*/*/*_neon.* entry would still be needed though. > > IBM POWER (alpha) > M: David Christensen <d...@linux.vnet.ibm.com> > +F: config/ppc/ > F: lib/librte_eal/ppc/ > -F: drivers/net/i40e/i40e_rxtx_vec_altivec.c > +F: drivers/*/*/*_altivec.* > F: examples/l3fwd/*altivec.h Idem neon, lib files missing. ./lib/librte_eal/ppc/include/rte_altivec.h ./lib/librte_acl/acl_run_altivec.c ./lib/librte_acl/acl_run_altivec.h ./lib/librte_lpm/rte_lpm_altivec.h ./examples/l3fwd/l3fwd_altivec.h ./examples/l3fwd/l3fwd_lpm_altivec.h ./drivers/net/mlx5/mlx5_rxtx_vec_altivec.h ./drivers/net/virtio/virtio_rxtx_simple_altivec.c ./drivers/net/i40e/i40e_rxtx_vec_altivec.c > > Intel x86 > M: Bruce Richardson <bruce.richard...@intel.com> > M: Konstantin Ananyev <konstantin.anan...@intel.com> > +F: config/x86/ > F: lib/librte_eal/x86/ Nothing for avx/sse ? > > Linux EAL (with overlaps) > -- > 2.28.0 > -- David Marchand