Riverhead does not support LED control yet. It is perfectly fine to ignore LED set failure because of no support if configured LED mode is the default.
Signed-off-by: Andrew Rybchenko <[email protected]> Reviewed-by: Andy Moreton <[email protected]> --- drivers/common/sfc_efx/base/ef10_phy.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/common/sfc_efx/base/ef10_phy.c b/drivers/common/sfc_efx/base/ef10_phy.c index 3d07c254bf..74a18841d9 100644 --- a/drivers/common/sfc_efx/base/ef10_phy.c +++ b/drivers/common/sfc_efx/base/ef10_phy.c @@ -530,8 +530,16 @@ ef10_phy_reconfigure( #endif rc = efx_mcdi_phy_set_led(enp, phy_led_mode); - if (rc != 0) + if (rc != 0) { + /* + * If LED control is not supported by firmware, we can + * silently ignore default mode set failure + * (see FWRIVERHD-198). + */ + if (rc == EOPNOTSUPP && phy_led_mode == EFX_PHY_LED_DEFAULT) + goto out; goto fail3; + } out: return (0); -- 2.17.1
