14/10/2020 08:19, Eli Britstein: > The cited commit introduced functions with 'int memory_order' argument. > The C11 standard section 7.17.1.4 defines 'memory_order' as the > "enumerated type whose enumerators identify memory ordering constraints". > Applications that use the standard enum (includes stdatomic.h), will > fail compilation with: > error: declaration of 'memory_order' shadows a global declaration > [-Werror=shadow] > rte_atomic_thread_fence(int memory_order) > Fix it by changing the argument name 'memory_order' to 'memorder'.
Not clear why it builds fine with most compilers, but the fix does not hurt. > Fixes: 672a15056380 ("eal: add wrapper for C11 atomic thread fence") A blank line should be inserted here. > Signed-off-by: Eli Britstein <el...@nvidia.com> Acked-by: Thomas Monjalon <tho...@monjalon.net>