On Fri, Oct 09, 2020 at 09:17:22AM +0800, Suanming Mou wrote:
> Add pthread mutex lock as it is needed for the thread safe rte_flow
> functions.
>
> Signed-off-by: Suanming Mou <suanmi...@nvidia.com>
> Acked-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com>
> ---
>
> v4:
> - Add PTHREAD_MUTEX_INITIALIZER macro.
>
> v3:
> - No updates.
>
> v2:
> - Using critical section for windows pthread mutex.
>
> ---
>
> lib/librte_eal/windows/include/pthread.h | 35
> ++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/lib/librte_eal/windows/include/pthread.h
> b/lib/librte_eal/windows/include/pthread.h
> index 99013dc..c62251f 100644
> --- a/lib/librte_eal/windows/include/pthread.h
> +++ b/lib/librte_eal/windows/include/pthread.h
> @@ -28,6 +28,12 @@
> /* defining pthread_attr_t type on Windows since there is no in Microsoft
> libc*/
> typedef void *pthread_attr_t;
>
> +typedef void *pthread_mutexattr_t;
> +
> +typedef CRITICAL_SECTION pthread_mutex_t;
> +
> +#define PTHREAD_MUTEX_INITIALIZER {(void *)-1, -1, 0, 0, 0, 0}
> +
Regarding the question on the static initializer, adding the guidance from
DmitryM:
"If you choose to do the static initializer, you will be relying on
implementation specifics,
(which may have not changed ever, or may not ever change, or may change in the
next release).
This would be a hack (although potentially long term)."
Otherwise,
Acked-by: Narcisa Vasile <navas...@linux.microsoft.com>
