> -----Original Message----- > From: Thomas Monjalon <[email protected]> > Sent: Tuesday, October 27, 2020 06:20 > To: [email protected] > Cc: Yigit, Ferruh <[email protected]>; [email protected]; > Richardson, Bruce > <[email protected]>; [email protected]; > [email protected]; > [email protected]; Doherty, Declan <[email protected]>; Ankur > Dwivedi <[email protected]>; > Anoob Joseph <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue > <[email protected]>; > Jerin Jacob <[email protected]>; Nithin Dabilpuram > <[email protected]>; Kiran Kumar K > <[email protected]>; Nicolau, Radu <[email protected]>; Ray > Kinsella <[email protected]>; Neil > Horman <[email protected]> > Subject: [PATCH v2 05/15] security: switch metadata to dynamic mbuf field > > The device-specific metadata was stored in the deprecated field udata64. > It is moved to a dynamic mbuf field in order to allow removal of udata64. > > Signed-off-by: Thomas Monjalon <[email protected]> > --- > doc/guides/prog_guide/rte_security.rst | 9 +++--- > drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 5 ++- > drivers/net/ixgbe/ixgbe_ipsec.c | 5 ++- > drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++-- > drivers/net/octeontx2/otx2_ethdev.h | 1 + > drivers/net/octeontx2/otx2_ethdev_sec.c | 5 ++- > drivers/net/octeontx2/otx2_ethdev_sec_tx.h | 2 +- > drivers/net/octeontx2/otx2_rx.h | 2 +- > examples/ipsec-secgw/ipsec-secgw.c | 9 +++--- > examples/ipsec-secgw/ipsec_worker.c | 12 ++++--- > lib/librte_security/rte_security.c | 22 +++++++++++++ > lib/librte_security/rte_security.h | 32 +++++++++++++++++++ > lib/librte_security/rte_security_driver.h | 3 ++ > lib/librte_security/version.map | 3 ++ > 14 files changed, 96 insertions(+), 20 deletions(-) >
For ixgbe PMD, Acked-by: Haiyue Wang <[email protected]> But I feel that 'rte_security_dynfield' name is too generic, can it be more specific about what the field is used for ? Like below ;-) #define RTE_SECURITY_DEV_METADATA(m) \ RTE_MBUF_DYNFIELD((m), \ rte_security_dev_metadata_offset, \ RTE_SECURITY_DEV_METADATA_TYPE *) > +/** > + * Get pointer to mbuf field for device-specific metadata. > + * > + * For performance reason, no check is done, > + * the dynamic field may not be registered. > + * @see rte_security_dynfield_is_registered > + * > + * @param mbuf packet to access > + * @return pointer to mbuf field > + */ > +static inline RTE_SECURITY_DYNFIELD_TYPE * > +rte_security_dynfield(struct rte_mbuf *mbuf) > +{ > + return RTE_MBUF_DYNFIELD(mbuf, > + rte_security_dynfield_offset, > + RTE_SECURITY_DYNFIELD_TYPE *); > +} > -- > 2.28.0
