> -----Original Message-----
> From: Ori Kam <[email protected]>
> Sent: Tuesday, December 29, 2020 12:13 PM
> To: Stephen Hemminger <[email protected]>; Shiri Kuzin
> <[email protected]>
> Cc: [email protected]; Slava Ovsiienko <[email protected]>; NBU-
> Contact-Adrien Mazarguil <[email protected]>;
> [email protected]; NBU-Contact-Thomas Monjalon
> <[email protected]>; Raslan Darawsheh <[email protected]>
> Subject: RE: [dpdk-dev] [PATCH 1/8] lib/librte_ethdev: introduce GENEVE
> header TLV option item
> 
> 
> 
> > -----Original Message-----
> > From: Stephen Hemminger <[email protected]>
> >
> > On Sun, 27 Dec 2020 18:06:16 +0200
> > Shiri Kuzin <[email protected]> wrote:
> >
> > > +#ifdef PEDANTIC
> > > +#pragma GCC diagnostic ignored "-Wpedantic"
> > > +#endif
> >
> > Please do not introduce pragma's for pedantic in standard headers.
> > It just clutters the code unnecessarily. The rest of DPDK is not
> > guaranteed to be free of pedantic warnings, so starting now is not worth
> the mess.
> 
> +1
> 
> Thanks,
> Ori

Thank you for the comment.
I will update it in the revised patch set.

Thanks,
Shiri.

Reply via email to