Hi Olivier,
On Wed, Jan 6, 2021 at 6:21 AM Olivier Matz <olivier.m...@6wind.com> wrote:
>
> Hi Ashish,
>
> Yes, it should reference the patch that introduced the issue. In this case,
> it should be:
>
> Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
>
> Can you please also change the title to start with "fix", for
> instance like this:
>
> mbuf: fix inclusion from c++
>
> You can also add "Cc: sta...@dpdk.org" in the commit log.
>
> Some documentation can be found in doc/guides/contributing/patches.rst
Thanks for the pointers. I've made the changes above. However I don't
know if I'm using the message ID for --in-reply-to correctly, since I
seem to be creating a new thread each time.
Thanks,
Ashish.
>
> Thanks,
> Olivier
>
>
> > PS: this is my first time submitting a patch to DPDK, so forgive me if this
> > is covered in the contributing doc, but I couldn't find anything that
> > applied to this situation
> >
> > On Tue, Dec 29, 2020 at 1:10 PM Stephen Hemminger <
> > step...@networkplumber.org> wrote:
> >
> > > On Tue, 29 Dec 2020 12:41:44 -0700
> > > Ashish Sadanandan <ashish.sadanan...@gmail.com> wrote:
> > >
> > > > The header was missing the extern "C" directive which causes name
> > > > mangling of functions by C++ compilers, leading to linker errors
> > > > complaining of undefined references to these functions.
> > > >
> > > > Signed-off-by: Ashish Sadanandan <ashish.sadanan...@gmail.com>
> > >
> > > Could you add a Fixes tag please?
> > >
