[dpdk-dev] [PATCH 1/3] nic_uio: Fix to allow any device to be bound to nic_uio

[Rahul Lakkireddy]

nic_uio requires the pci ids to be present in rte_pci_dev_ids.h in order to
bind the devices to nic_uio.  However, it's better to remove this whitelist of
pci ids, and instead rely on hw.nic_uio.bdfs kenv parameter to allow binding
any device to nic_uio.

Suggested-by: David Marchand <david.marchand at 6wind.com>
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy at chelsio.com>
Signed-off-by: Kumar Sanghvi <kumaras at chelsio.com>
---
 lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 46 +++++++++------------------------
 1 file changed, 12 insertions(+), 34 deletions(-)

diff --git a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c 
b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
index 2354e84..eca53de 100644
--- a/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
+++ b/lib/librte_eal/bsdapp/nic_uio/nic_uio.c
@@ -106,24 +106,6 @@ struct pci_bdf {
        uint32_t function;
 };

-
-#define RTE_PCI_DEV_ID_DECL_EM(vend, dev)      {vend, dev},
-#define RTE_PCI_DEV_ID_DECL_IGB(vend, dev)     {vend, dev},
-#define RTE_PCI_DEV_ID_DECL_IGBVF(vend, dev)   {vend, dev},
-#define RTE_PCI_DEV_ID_DECL_IXGBE(vend, dev)   {vend, dev},
-#define RTE_PCI_DEV_ID_DECL_IXGBEVF(vend, dev) {vend, dev},
-#define RTE_PCI_DEV_ID_DECL_I40E(vend, dev)    {vend, dev},
-#define RTE_PCI_DEV_ID_DECL_I40EVF(vend, dev)  {vend, dev},
-#define RTE_PCI_DEV_ID_DECL_VIRTIO(vend, dev)  {vend, dev},
-#define RTE_PCI_DEV_ID_DECL_VMXNET3(vend, dev) {vend, dev},
-#define RTE_PCI_DEV_ID_DECL_ENIC(vend, dev)    {vend, dev},
-
-const struct device devices[] = {
-#include <rte_pci_dev_ids.h>
-};
-#define NUM_DEVICES (sizeof(devices)/sizeof(devices[0]))
-
-
 static devclass_t nic_uio_devclass;

 DEFINE_CLASS_0(nic_uio, nic_uio_driver, nic_uio_methods, sizeof(struct 
nic_uio_softc));
@@ -195,10 +177,9 @@ nic_uio_probe (device_t dev)
 {
        int i;

-       for (i = 0; i < NUM_DEVICES; i++)
-               if (pci_get_vendor(dev) == devices[i].vend &&
-                       pci_get_device(dev) == devices[i].dev) {
-
+       for (i = 0; i < num_detached; i++)
+               if (pci_get_vendor(dev) == pci_get_vendor(detached_devices[i]) 
&&
+                   pci_get_device(dev) == pci_get_device(detached_devices[i])) 
{
                        device_set_desc(dev, "Intel(R) DPDK PCI Device");
                        return BUS_PROBE_SPECIFIC;
                }
@@ -256,7 +237,6 @@ static void
 nic_uio_load(void)
 {
        uint32_t bus, device, function;
-       int i;
        device_t dev;
        char bdf_str[256];
        char *token, *remaining;
@@ -295,17 +275,15 @@ nic_uio_load(void)
                if (dev == NULL)
                        continue;

-               for (i = 0; i < NUM_DEVICES; i++)
-                       if (pci_get_vendor(dev) == devices[i].vend &&
-                                       pci_get_device(dev) == devices[i].dev) {
-                                               if (num_detached < 
MAX_DETACHED_DEVICES) {
-                                                       printf("nic_uio_load: 
detaching and storing dev=%p\n", dev);
-                                                       
detached_devices[num_detached++] = dev;
-                                               } else
-                                                       printf("nic_uio_load: 
reached MAX_DETACHED_DEVICES=%d. dev=%p won't be reattached\n",
-                                                               
MAX_DETACHED_DEVICES, dev);
-                                               device_detach(dev);
-                       }
+               if (num_detached < MAX_DETACHED_DEVICES) {
+                       printf("nic_uio_load: detaching and storing dev=%p\n",
+                              dev);
+                       detached_devices[num_detached++] = dev;
+               } else {
+                       printf("nic_uio_load: reached MAX_DETACHED_DEVICES=%d. 
dev=%p won't be reattached\n",
+                              MAX_DETACHED_DEVICES, dev);
+               }
+               device_detach(dev);
        }
 }

-- 
2.4.1