On Tue, 12 Jan 2021 14:33:41 -0800, Tyler Retzlaff wrote:
> DEVCLASS and DEVINTERFACE guids are defined/managed by the windows
> platform sdk headers.
Please write names and acronyms in proper case in all human-readable text
(commit subject except topic, commit message, log messages).
> * hide dpdk defined GUID_DEVCLASS_NETUIO and GUID_DEVINTERFACE_NETUIO if
> the NTDDI_VERSION >= 0x0A00000A
> * include <ndisguid.h> for windows sdk defined GUID_DEVINTERFACE_NETUIO
This translates the code almost verbatim, not needed. Instead you could state
which SDK versions are affected. Suggested wording:
pci/windows: fix build with SDK 10.0.xxxxx
NetUIO device class and interface GUIDs are defined in system
headers starting from platform SDK v10.0.xxxxx. Inspect SDK version
to avoid redefinition.
Fixes: hhhhhhhhhhhh ("...")
Cc: sta...@dpdk.org
Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com>
I can't find which "xxxxx" corresponds to NTDDI_WIN10_FE.
"hhhhhhhhhhhh" are 12 chars of the hash of the commit which introduced the
code you fixed. "..." is said commit subject. This info is needed to backport
your fix to stable branch, so that it can also be built with newer SDK. May
not be very important until Windows port gets its users, I mostly tell it to
illustrate the process.
> +#if (! defined(NTDDI_WIN10_FE) || NTDDI_VERSION < NTDDI_WIN10_FE)
Braces are redundant here and DPDK style is to avoid them (see rte_common.h).
