Hi Ferruh,

> -----Original Message-----
> From: Ferruh Yigit <[email protected]>
> Sent: Wednesday, January 27, 2021 8:50 PM
> To: Jiawei(Jonny) Wang <[email protected]>; Slava Ovsiienko
> <[email protected]>; Matan Azrad <[email protected]>; Ori Kam
> <[email protected]>; NBU-Contact-Thomas Monjalon
> <[email protected]>
> Cc: [email protected]; Raslan Darawsheh <[email protected]>;
> [email protected]; Kevin Traynor <[email protected]>; Luca Boccassi
> <[email protected]>
> Subject: Re: [dpdk-stable] [PATCH 2/2] net/mlx5: use global default miss for
> E-Switch sampling
> 
> On 1/26/2021 12:53 PM, Jiawei Wang wrote:
> > In E-Switch steering domain there was dedicated default miss action
> > created for every sampling flow.
> > The patch replaces this one with the global default miss action.
> >
> 
> Hi Jiawei,
> 
> The impact of the patch is not clear, what was the problem using action per
> flow? What will change when global action is used? Is this fixing some
> problem or is it optimization by preventing per flow action?
> 

The patch is optimization not fix,  MLX5 PMD can reuses the global action don’t 
need allocate new one each time. 

> > Cc: [email protected]
> >
> 
> Since this looks like optimization, I am removing the stable tag for now.

Yes,  please remove this tag.
Thanks.

> 
> If it is a fix, please reply with a fixes line, I can update it in next-net.
> 
> > Signed-off-by: Jiawei Wang <[email protected]>
> > Acked-by: Viacheslav Ovsiienko <[email protected]>

Reply via email to